Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between Kubevirt and OpenShift Virtualization #1815

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

nasark
Copy link
Member

@nasark nasark commented Sep 25, 2024

Post subclassing OSV, we should differentiate it as a separate provider from Kubevirt in the docs

@miq-bot assign @agrare
@miq-bot add_labels enhancement, radjabov/yes?
@miq-bot add_reviewers @agrare, @Fryguy

| Events | ✅ | ✅ | ✅ | ✅ | ❌ |
| Metrics | ✅ | ✅ | ✅ | ✅ | ❌ |
| Forensic Analysis (SmartState) | ✅ | ✅ | ✅ (Nodes) | ❌ | ❌ |
| Discovery | vSphere | oVirt / RHV | OpenStack undercloud | IBM Power HMC | KubeVirt | OSV |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we show the other subclassed providers together, oVirt / RHV
Could we do | KubeVirt / OSV | at least until we have any differentiation between the two in features supported

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need to update the capability matrix with KubeVirt / OSV

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is there https://github.com/ManageIQ/manageiq-documentation/blob/master/capabilities_matrix/_topics/infrastructure_providers.md, the earlier change was just to separate it but no longer doing that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 I didn't see that in the diff, thanks

@qahmed1998
Copy link
Contributor

qahmed1998 commented Oct 24, 2024

@Fryguy @agrare
OpenShift Virtualization is added as a new entry under capabilities_matrix/_topics/providers.md

So in this table we have two separate entries, one for OpenShift Virtualization and another for KubeVirt.

Keeping the above in mind do we also want to make the changes here as well or does the list in the following picture remains the same?
image

i.e The list for Infrastructure Providers becomes:

  • Red Hat Virtualization Providers
  • OpenStack Infrastructure Providers
  • VMware vCenter
  • IBM Power HMC
  • OpenShift Virtualization
  • KubeVirt

@Fryguy
Copy link
Member

Fryguy commented Oct 24, 2024

Interestingly, Red Hat Virtualization and oVirt are in a similar case where they are really basically the same. In other places we just put them together to avoid the redundancy, (e.g. RHV/oVirt), so I personally prefer that for OSV/KubeVirt

@qahmed1998
Copy link
Contributor

Thanks Jason. I am adding my approval for the PR in that case.

@agrare agrare merged commit df50a8c into ManageIQ:master Oct 28, 2024
2 checks passed
github-actions bot pushed a commit to ManageIQ/manageiq.github.io that referenced this pull request Oct 28, 2024
@Fryguy
Copy link
Member

Fryguy commented Oct 30, 2024

Backported to radjabov in commit 6a1c53b.

commit 6a1c53bd27827a3689362c23eee015d02e5f3de4
Author: Adam Grare <[email protected]>
Date:   Mon Oct 28 08:32:46 2024 -0400

    Merge pull request #1815 from nasark/osv_provider_changes
    
    Differentiate between Kubevirt and OpenShift Virtualization
    
    (cherry picked from commit df50a8cf4c98236edd8cfdd4859f42e731dda5fb)

Fryguy pushed a commit that referenced this pull request Oct 30, 2024
Differentiate between Kubevirt and OpenShift Virtualization

(cherry picked from commit df50a8c)
github-actions bot pushed a commit to ManageIQ/manageiq.github.io that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants